https://bugzilla.redhat.com/show_bug.cgi?id=2013614 --- Comment #5 from Ibiam <ibiamchihurumnaya@xxxxxxxxx> --- (In reply to Miro Hrončok from comment #4) > %build > python3 setup.py build > > %install > python3 setup.py install --prefix=%{buildroot}/%{_prefix} > > > > Why not %py3_build and %py3_install? See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ > #_example_python_spec_file I used %build and %install to maintain the convention used for the sugar packages, thanks for letting me know about %py3_build and %py3_install. I'll look at switching them. > > > > > rm %{buildroot}%{_prefix}/share/applications/*.desktop || true > > > Why do you do this? The desktop files create icons for running activities outside of sugar on other desktop environments and running an activity from it's icon was made to be just from the sugar desktop, that's why they're removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013614 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
