https://bugzilla.redhat.com/show_bug.cgi?id=2016693 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(vanessaigwe1@gmai |in.net) |l.com) |needinfo?(code@musicinmybra | |in.net) | --- Comment #15 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > @code@xxxxxxxxxxxxxxxxxx I didn't include the PDF docs hoping I could include it at a later time if it won't be a block for the package approval Of course—building and installing the Sphinx documentation is a choice, not a requirement. Thanks for your careful work on updating this spec file! I see only one small thing, that needs to be adjusted before I can approve the package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. (OK; fedora-review does not understand rpmautospec) - The “Requires: openjpeg2” should be on the python3-glymur subpackage. Note that a Requires always applies to a particular binary RPM. Different subpackage typically have different Requires (both manual and generated). Because the base package python-glymur has no %files section and does not build a binary RPM, putting the Requires here has no effect. This is a very common mistake. (BuildRequires are different; they can be all on the base package, or some on different subpackages. It does not really matter where you put them, so it is a matter of personal style preference. They all belong to the source RPM.) - This one is really non-obvious: rpmlint says: python-glymur.src:76: W: macro-in-%changelog %autorelease python-glymur.src:76: W: macro-in-%changelog %changelog python-glymur.src:76: W: macro-in-%changelog %autochangelog You very reasonably mentioned %autorelease, %changelog, and %autochangelog in a commit message, but rpmautospec does not escape the percent signs (by doubling, e.g. %%autorelease) when creating the changelog. The macros can then be expanded, which can cause all kinds of trouble. I think this is a significant bug (https://pagure.io/fedora-infra/rpmautospec/issue/224), but for now it’s important to always manually escape percent characters in commit messages when using rpmautospec. This doesn’t block approval because the changelogs from your pagure repository won’t be carried over to the new dist-git repository after approval. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Creative Commons CC0 Universal 1.0 Public Domain Dedication". 103 files have unknown license. Detailed output of licensecheck in /home/reviewer/2016693-python- glymur/20211029/2016693-python-glymur/licensecheck.txt CC0 files in ci/ are not installed, so do not affect the binary package’s license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. The “Requires: openjpeg2” should be on the python3-glymur package. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). The “Requires: openjpeg2” should be on the python3-glymur package. [!]: Package functions as described. Needs working openjpeg2 dependency. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK; fedora-review does not understand rpmautospec [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-glymur-0.9.4-8.fc36.noarch.rpm python-glymur-0.9.4-8.fc36.src.rpm python-glymur.src: W: strange-permission python-glymur.spec 600 python-glymur.src:76: W: macro-in-%changelog %autorelease python-glymur.src:76: W: macro-in-%changelog %changelog python-glymur.src:76: W: macro-in-%changelog %autochangelog 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/quintusdias/glymur/archive/v0.9.4/python-glymur-0.9.4.tar.gz : CHECKSUM(SHA256) this package : b7490314c5aebf338facc603f7dde2ec807860bf0ff226df634ee90065a2fcd1 CHECKSUM(SHA256) upstream package : b7490314c5aebf338facc603f7dde2ec807860bf0ff226df634ee90065a2fcd1 Requires -------- python3-glymur (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.10dist(lxml) python3.10dist(numpy) python3.10dist(setuptools) Provides -------- python3-glymur: python-glymur python3-glymur python3.10-glymur python3.10dist(glymur) python3dist(glymur) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/2016693-python-glymur/20211029/2016693-python-glymur/srpm/python-glymur.spec 2021-10-29 14:33:20.569550737 -0400 +++ /home/reviewer/2016693-python-glymur/20211029/2016693-python-glymur/srpm-unpacked/python-glymur.spec 2021-10-29 08:35:12.000000000 -0400 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.5) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 8; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + Name: python-glymur Version: 0.9.4 @@ -58,3 +67,25 @@ %changelog -%autochangelog \ No newline at end of file +* Fri Oct 29 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-8 +- Uncommitted changes + +* Thu Oct 28 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-7 +- added CHANGES.txt to package docs + +* Mon Oct 25 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-6 +- changed Release = %autorelease and %changelog = %autochangelog + +* Mon Oct 25 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-5 +- updated spec file + +* Fri Oct 22 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-4 +- fresh mockbuild for review + +* Fri Oct 22 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-3 +- sending for review + +* Fri Oct 22 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-2 +- rpm package created successfully + +* Thu Oct 21 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.9.4-1 +- building process ... Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2016693 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Ocaml, Java, R, PHP, C/C++, Perl, SugarActivity, fonts, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2016693 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
