https://bugzilla.redhat.com/show_bug.cgi?id=2008657 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(david08741@gmail. |in.net) |com) --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to david08741 from comment #6) > I tried > > packages=find_packages(exclude="*.tests*"), > and it doesn't work. That’s because there was a typo in my suggestion. It should have been > packages=find_packages(exclude=["*.tests*"]), which I *did* test. ----- > Even more troubling I noticed that a non-free (CC BY-NC 2.0) image is > included in the source, I will ask upstream to remove it. Wow, nice catch. I missed that in the initial review, since the license was only mentioned in README.md. Upstream has updated to 0.5.5 with a CC0 image. If it were installed, it could be handled like: > # The entire source is MIT except resources/gelidum.jpg, which is CC0 > License: MIT and CC0 but since it is not installed, the overall license can stay just “MIT”. For clarity, you might still want a comment like: > # The entire source is MIT except resources/gelidum.jpg, which is CC0 (and is > # not installed) ----- I’ll wait for you to update to 0.5.5 before re-reviewing. Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2008657 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
