Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: snake - a client/server python framework used to support anaconda installations https://bugzilla.redhat.com/show_bug.cgi?id=391091 ------- Additional Comments From jlaska@xxxxxxxxxx 2007-11-26 16:39 EST ------- (In reply to comment #7) > Latest pass through the spec: > > 1) the lines between %prep and %setup probably shouldn't be there, %setup is a > macro used in the %prep section, not a new section. :) Thanks, fixed > 2) I still see 6 /var and 2 /etc used instead of %{_localstatedir} and > %{_sysconfdir}, respectively. My apologies ... I misinterpreted and thought the request was to remove usage of those macros. Okay, I've made appropriate changes. > * License field in spec matches actual license > **** NOTE: **** > Interesting tidbit here... You have both a COPYING and a LICENSE file, which are > *almost*, but *not quite* the same file... You really only need one or the > other, and it looks like the main difference between them are the address listed > for the FSF and Lesser vs. Library. Removed COPYING in favor of LICENSE file > * sources used match the upstream source, as provided in spec URL. Verify with > md5sum (if no upstream URL, source creation method must be documented and can be > verified using diff). > **** FIXME **** > Oops. I missed this on the initial passes through the spec... Granted, its a git > snap, but in that case, we need a bit of documentation on how the snap was > produced. And once a 'stable' release is out, there ought to be tarballs > available that you point to. Maybe check out how Jesse does things for Pungi. Okay, I've updated the spec file to use a url to point to the releases. Additionally, I have created a releases page on the hosted.fedoraproject.org snake page that includes the spec, tarball, and src.rpm package (https://hosted.fedoraproject.org/projects/snake/wiki/SnakeReleases). Hopefully this addresses it. > * package owns all directories it creates: > **** FIXME **** > Just noticed that it doesn't look like the resulting binaries own > /var/lib/snake. Just need to add a '%dir %{_localstatedir}/lib/snake' above the > lines in '%files server' that own the sub-directories of that directory. Doh! Good catch, changes commited > * macros used consistently > **** FIXME **** > Just need to get the /var and /etc replacements in there. This should be addressed now Updated spec and src.rpm available ... Spec URL: http://jlaska.fedorapeople.org/snake/snake.spec SRPM URL: http://jlaska.fedorapeople.org/snake/snake-0.9-0.4git.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review