https://bugzilla.redhat.com/show_bug.cgi?id=2017670 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Note that conditional source definitions are discouraged (forbidden?) because they prevent an SRPM generated with one bcond-value to be re-used to build with another bcond-value. I also think this special "use a wheel for bootstrap" case deserves some explanation in a comment. I would especially note that any patches are not applied to the wheel and if we need to do that, special care needs to be applied. The duplicated %build/%install section seems a bit unusual, have you considered repeating the conditional in the sections instead? %prep %autosetup -p1 -n tomli-w-%{version} %if %{without bootstrap} %generate_buildrequires %pyproject_buildrequires -t %endif %build %if %{with bootstrap} mkdir -p %{_pyproject_wheeldir} cp -p %{SOURCE1} %{_pyproject_wheeldir} %else %pyproject_wheel %endif %install %pyproject_install %pyproject_save_files tomli_w %if %{without bootstrap} %check %tox %endif %files -n python3-tomli-w -f %{pyproject_files} %doc README.md %doc CHANGELOG.md %license LICENSE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2017670 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
