https://bugzilla.redhat.com/show_bug.cgi?id=2017459 --- Comment #2 from Petr Menšík <pemensik@xxxxxxxxxx> --- I would use %{URL} in Source0, since the base is common with URL: tag Source0: %{URL}/archive/v%{version}.tar.gz I am not sure what is a reason for -static library. Do you ever need that? I would disable via %bcond_with or remove altogether. All packages in Fedora MUST and should use dynamic library version. Users should usually use shared libraries on the same machine. Unless you need it for something, I would remove that part [1]. Not mandatory however. But those are just cosmetic issues. I think the spec is good and can be granted. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2017459 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
