https://bugzilla.redhat.com/show_bug.cgi?id=2006590 Denis Fateyev <denis@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(denis@xxxxxxxxxxx | |) | --- Comment #3 from Denis Fateyev <denis@xxxxxxxxxxx> --- (In reply to Ben Beasley from comment #2) > > - Architecture-specific "devel" packages are actually identical: they provide the same "earcut.hpp" source file version. > > The difference is in the testing suite flow, but for an end-user they all provide the same content. > > Please consider changing devel package to "noarch". > > This seems reasonable—especially leaving the base package arched to run the > tests on all architectures, while marking the -devel subpackage noarch—and I > have used this approach on Python packages that have no compiled code but > are prone to arch-dependent test failures. > > However, for header-only library packages like this one, the guidelines > actually forbid using noarch: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_do_not_use_noarch OK, I have just seen this requirement. Honestly, it looks a bit incomplete in the guidelines: to put headers into arch-specific packages only to satisfy arch-specific tests, when the "library should have tests which should be run on all architectures" condition can be archived a better way. Also, there is no "install process may modify the installed headers depending on the build architecture" situation. Anyway, the package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2006590 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
