https://bugzilla.redhat.com/show_bug.cgi?id=2006590 Denis Fateyev <denis@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) Status|NEW |ASSIGNED --- Comment #1 from Denis Fateyev <denis@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. Fedora-review reports a dist tag presence, but it seems a false positive and can be ignored. - Architecture-specific "devel" packages are actually identical: they provide the same "earcut.hpp" source file version. The difference is in the testing suite flow, but for an end-user they all provide the same content. Please consider changing devel package to "noarch". ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License", "*No copyright* [generated file]", "SGI Free Software License B v2.0". 16 files have unknown license. Detailed output of licensecheck in /home/mock/sandbox/review/2006590-earcut-hpp/licensecheck.txt Note: licensecheck reports "SGI Free Software License", but it's related to test suite only. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/mapbox(geometry- hpp-devel, mapbox-variant-devel, wagyu-devel) Note: looks good. No dependency chain from packages above. Ownership rules are correct. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. Note: requires %autochangelog macros working in advance, otherwise produces bogus results. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [!]: Package complies to the Packaging Guidelines Note: all architecture-specific builds are identical, "noarch" usage is expected [-]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). Note: provides should be no arch specific [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: earcut-hpp-devel-2.2.3-1.fc36.x86_64.rpm earcut-hpp-2.2.3-1.fc36.src.rpm earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US degeneracies -> degenerates, degeneracy, DeGeneres earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US doesn -> does, does n earcut-hpp.src: W: spelling-error %description -l en_US js -> dis, ks, j earcut-hpp.src: W: spelling-error %description -l en_US degeneracies -> degenerates, degeneracy, DeGeneres earcut-hpp.src: W: spelling-error %description -l en_US doesn -> does, does n earcut-hpp.src:113: W: macro-in-%changelog %autochangelog 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US degeneracies -> degenerates, degeneracy, DeGeneres earcut-hpp-devel.x86_64: W: spelling-error %description -l en_US doesn -> does, does n 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://github.com/mapbox/earcut.hpp/archive/v2.2.3/earcut.hpp-2.2.3.tar.gz : CHECKSUM(SHA256) this package : f382616de763289c698f37ec3a5b9fcd3d6d821cbef0b3c72e43bdd909c81b5a CHECKSUM(SHA256) upstream package : f382616de763289c698f37ec3a5b9fcd3d6d821cbef0b3c72e43bdd909c81b5a Requires -------- earcut-hpp-devel (rpmlib, GLIBC filtered): Provides -------- earcut-hpp-devel: earcut-hpp-devel earcut-hpp-devel(x86-64) earcut-hpp-static License check -------- *No copyright* [generated file] -------------------------------- earcut.hpp-2.2.3/test/convert_tests.js earcut.hpp-2.2.3/test/fixtures/bad_diagonals.cpp earcut.hpp-2.2.3/test/fixtures/bad_hole.cpp earcut.hpp-2.2.3/test/fixtures/boxy.cpp earcut.hpp-2.2.3/test/fixtures/building.cpp earcut.hpp-2.2.3/test/fixtures/collinear_diagonal.cpp earcut.hpp-2.2.3/test/fixtures/degenerate.cpp earcut.hpp-2.2.3/test/fixtures/dude.cpp earcut.hpp-2.2.3/test/fixtures/eberly_3.cpp earcut.hpp-2.2.3/test/fixtures/eberly_6.cpp earcut.hpp-2.2.3/test/fixtures/empty_square.cpp earcut.hpp-2.2.3/test/fixtures/hilbert.cpp earcut.hpp-2.2.3/test/fixtures/hole_touching_outer.cpp earcut.hpp-2.2.3/test/fixtures/hourglass.cpp earcut.hpp-2.2.3/test/fixtures/issue107.cpp earcut.hpp-2.2.3/test/fixtures/issue111.cpp earcut.hpp-2.2.3/test/fixtures/issue119.cpp earcut.hpp-2.2.3/test/fixtures/issue131.cpp earcut.hpp-2.2.3/test/fixtures/issue135.cpp earcut.hpp-2.2.3/test/fixtures/issue16.cpp earcut.hpp-2.2.3/test/fixtures/issue17.cpp earcut.hpp-2.2.3/test/fixtures/issue29.cpp earcut.hpp-2.2.3/test/fixtures/issue34.cpp earcut.hpp-2.2.3/test/fixtures/issue35.cpp earcut.hpp-2.2.3/test/fixtures/issue45.cpp earcut.hpp-2.2.3/test/fixtures/issue52.cpp earcut.hpp-2.2.3/test/fixtures/issue83.cpp earcut.hpp-2.2.3/test/fixtures/outside_ring.cpp earcut.hpp-2.2.3/test/fixtures/rain.cpp earcut.hpp-2.2.3/test/fixtures/self_touching.cpp earcut.hpp-2.2.3/test/fixtures/shared_points.cpp earcut.hpp-2.2.3/test/fixtures/simplified_us_border.cpp earcut.hpp-2.2.3/test/fixtures/steiner.cpp earcut.hpp-2.2.3/test/fixtures/touching2.cpp earcut.hpp-2.2.3/test/fixtures/touching3.cpp earcut.hpp-2.2.3/test/fixtures/touching4.cpp earcut.hpp-2.2.3/test/fixtures/touching_holes.cpp earcut.hpp-2.2.3/test/fixtures/water.cpp earcut.hpp-2.2.3/test/fixtures/water2.cpp earcut.hpp-2.2.3/test/fixtures/water3.cpp earcut.hpp-2.2.3/test/fixtures/water3b.cpp earcut.hpp-2.2.3/test/fixtures/water4.cpp earcut.hpp-2.2.3/test/fixtures/water_huge.cpp earcut.hpp-2.2.3/test/fixtures/water_huge2.cpp ISC License ----------- earcut.hpp-2.2.3/LICENSE SGI Free Software License B v2.0 -------------------------------- earcut.hpp-2.2.3/test/comparison/libtess2/LICENSE.txt earcut.hpp-2.2.3/test/comparison/libtess2/bucketalloc.c earcut.hpp-2.2.3/test/comparison/libtess2/bucketalloc.h earcut.hpp-2.2.3/test/comparison/libtess2/dict.c earcut.hpp-2.2.3/test/comparison/libtess2/dict.h earcut.hpp-2.2.3/test/comparison/libtess2/geom.c earcut.hpp-2.2.3/test/comparison/libtess2/geom.h earcut.hpp-2.2.3/test/comparison/libtess2/mesh.c earcut.hpp-2.2.3/test/comparison/libtess2/mesh.h earcut.hpp-2.2.3/test/comparison/libtess2/priorityq.c earcut.hpp-2.2.3/test/comparison/libtess2/priorityq.h earcut.hpp-2.2.3/test/comparison/libtess2/sweep.c earcut.hpp-2.2.3/test/comparison/libtess2/sweep.h earcut.hpp-2.2.3/test/comparison/libtess2/tess.c earcut.hpp-2.2.3/test/comparison/libtess2/tess.h earcut.hpp-2.2.3/test/comparison/libtess2/tesselator.h Unknown or generated -------------------- earcut.hpp-2.2.3/.clang-format earcut.hpp-2.2.3/.gitmodules earcut.hpp-2.2.3/.travis.yml earcut.hpp-2.2.3/CHANGELOG.md earcut.hpp-2.2.3/CMakeLists.txt earcut.hpp-2.2.3/README.md earcut.hpp-2.2.3/appveyor.yml earcut.hpp-2.2.3/include/mapbox/earcut.hpp earcut.hpp-2.2.3/test/bench.cpp earcut.hpp-2.2.3/test/comparison/earcut.hpp earcut.hpp-2.2.3/test/comparison/libtess2.hpp earcut.hpp-2.2.3/test/fixtures/geometries.hpp earcut.hpp-2.2.3/test/tap.cpp earcut.hpp-2.2.3/test/tap.hpp earcut.hpp-2.2.3/test/test.cpp earcut.hpp-2.2.3/test/viz.cpp Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2006590 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, R, PHP, Java, Ocaml, fonts, SugarActivity, Perl, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2006590 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
