https://bugzilla.redhat.com/show_bug.cgi?id=2000219 --- Comment #14 from mkulik@xxxxxxxxxx --- No worries, I will try to finish this review. After your changes, package fails to pass automatic review build: > ERROR: 'mock build failed, see /home/mkulik/review-llvm-libunwind/results/build.log' This error is here now because you did not included static library in files but it is still present in installation: > Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/llvm-libunwind-13.0.0-1.fc36.x86_64 > error: Installed (but unpackaged) file(s) found: > /usr/lib64/llvm-unwind/libunwind.a > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/lib64/llvm-unwind/libunwind.a > Child return code was: 1 You can always try to check your package after modification with fedora-review tool. It will show you common error that are still present. You can address this error in many ways: 1. Delete static library in %install 2. Patch cmake to build without static library: https://github.com/llvm/llvm-project/blob/main/libunwind/CMakeLists.txt#L60 3. Ignore by setting _unpackaged_files_terminate_build I included 3rd option only to show that it exists. It should not be used in final package. Overall all looks fine now. I'll post final review after you fix this error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2000219 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
