https://bugzilla.redhat.com/show_bug.cgi?id=2014774 --- Comment #1 from Didik Supriadi <didiksupriadi41@xxxxxxxxx> --- Hi, I found an issue about duplicates in %files. > warning: File listed twice: /usr/share/java/truth It seems like you need to remove %dir %{_javadir}/%{name} because it's already listed in .mfiles These are not blockers: - You could simplified your spec files diff --git a/truth.spec b/truth.spec index 1e3e1db..0f5add9 100644 --- a/truth.spec +++ b/truth.spec @@ -28,11 +28,7 @@ Truth is a library provides alternative ways to express assertions in unit tests. It can be used as a replacement for JUnit's assertions or FEST or it can be used alongside where other approaches seem more suitable. -%package javadoc -Summary: Javadoc for %{name} - -%description javadoc -This package contains the API documentation for %{name}. +%{?javadoc_package} %prep %setup -q -n %{name}-release_0_42 @@ -61,8 +57,7 @@ This package contains the API documentation for %{name}. sed -i 's/1\.7/1.8/' pom.xml # Fix difflib -%pom_change_dep com.googlecode.java-diff-utils:diffutils io.github.java-diff-utils:java-diff-utils -%pom_change_dep com.googlecode.java-diff-utils:diffutils io.github.java-diff-utils:java-diff-utils core +%pom_change_dep com.googlecode.java-diff-utils:diffutils io.github.java-diff-utils:java-diff-utils . core find -name '*.java' -exec sed -i -e '/^import/s/ difflib\.Patch/ com.github.difflib.patch.Patch/' \ -e '/^import/s/ difflib\.DiffUtils\.generateUnifiedDiff;/ com.github.difflib.UnifiedDiffUtils.generateUnifiedDiff;/' \ -e '/^import/s/ difflib\./ com.github.difflib./' {} + @@ -95,9 +90,6 @@ find -name '*.java' | xargs sed -ri \ %files -f .mfiles %doc README.md -%dir %{_javadir}/%{name} -%license LICENSE -%files javadoc -f .mfiles-javadoc %license LICENSE - These are missing classes but I think it's fine (https://www.baeldung.com/java-package-info#purposes-of-package-info) [dsupriadi@fedora ~]$ diff-jars truth-0.42.jar truth.jar --- /tmp/truth-0.42.jar.list.yJMS4U 2021-10-24 11:29:52.686614185 +0700 +++ /tmp/truth.jar.list.d2KDXa 2021-10-24 11:29:52.980616306 +0700 @@ -87,7 +87,6 @@ com/google/common/truth/MultisetSubject.class com/google/common/truth/ObjectArraySubject.class com/google/common/truth/Ordered.class -com/google/common/truth/package-info.class com/google/common/truth/Platform$ComparisonFailureMessageStrategy.class com/google/common/truth/Platform$JUnitTestRule.class com/google/common/truth/Platform$PlatformComparisonFailure.class [dsupriadi@fedora ~]$ diff-jars truth-proto-extension-0.42.jar truth-proto-extension.jar --- /tmp/truth-proto-extension-0.42.jar.list.Ha3SOP 2021-10-24 11:30:05.075703546 +0700 +++ /tmp/truth-proto-extension.jar.list.ZoDRIw 2021-10-24 11:30:05.359705594 +0700 @@ -85,7 +85,6 @@ com/google/common/truth/extensions/proto/MultimapWithProtoValuesSubject$MultimapWithMessageValuesSubject.class com/google/common/truth/extensions/proto/MultimapWithProtoValuesSubject$MultimapWithProtoValuesFluentAssertionImpl.class com/google/common/truth/extensions/proto/MultimapWithProtoValuesSubject.class -com/google/common/truth/extensions/proto/package-info.class com/google/common/truth/extensions/proto/ProtoFluentAssertion.class com/google/common/truth/extensions/proto/ProtoSubject$1.class com/google/common/truth/extensions/proto/ProtoSubject$MessageSubject$1.class -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2014774 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
