https://bugzilla.redhat.com/show_bug.cgi?id=2013111 Gustavo Costa <xfgusta@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(xfgusta@xxxxxxxxx | |) | --- Comment #6 from Gustavo Costa <xfgusta@xxxxxxxxx> --- Hi Ben. I am new to the packager group (about three weeks ago), but I should have paid more attention to this review request. Anyway, thanks for the review. I updated the spec file as follows: I agree with you about the license, but I would like to point out that the upstream also maintains a package for Void Linux, and its license field uses Public Domain [1], although CC0-1.0 is also valid [2]. However, I changed from Public Domain to CC0 as you suggested I added the BuildRequires perl(Test::Harness) and the "%make_build check" in the %check section I also added your patch Spec URL: https://xfgusta.fedorapeople.org/packages/nq/nq.spec SRPM URL: https://xfgusta.fedorapeople.org/packages/nq/nq-0.4-1.fc34.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=77620356 1. https://github.com/void-linux/void-packages/blob/master/srcpkgs/nq/template#L8 2. https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013111 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
