https://bugzilla.redhat.com/show_bug.cgi?id=2011825 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Please switch source from www.cpan.org to metacpan.org > https://cpan.metacpan.org/modules/by-module/Compress/Compress-Stream-Zstd- > %{version}.tar.gz -Source0: https://www.cpan.org/modules/by-module/Compress/Compress-Stream-Zstd-%{version}.tar.gz +Source0: https://cpan.metacpan.org/modules/by-module/Compress/Compress-Stream-Zstd-%{version}.tar.gz Ok. > FIX: Please add build-requires: > coreutils - perl-Compress-Stream-Zstd.spec (line 42) > findutils - perl-Compress-Stream-Zstd.spec (line 39,40) > perl-interpreter - perl-Compress-Stream-Zstd.spec (line 20,33) > perl(Config) - builder/MyBuilder.pm:7 > perl(Devel::PPPort) - builder/MyBuilder.pm:50 > perl(File::Basename) - Build.PL:14 > perl(File::Spec) - Build.PL:15 > perl(utf8) - Build.PL:10 +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: perl-interpreter +BuildRequires: perl(Config) +BuildRequires: perl(Devel::PPPort) +BuildRequires: perl(ExtUtils::CBuilder) +BuildRequires: perl(File::Basename) +BuildRequires: perl(File::Spec) +BuildRequires: perl(utf8) Ok > FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 5.008001' because > the package has an epoch. -BuildRequires: perl >= 0:5.008001 +BuildRequires: perl(:VERSION) >= 5.8.1 Ok. > FIX: Please remove run-require 'perl(parent)'. It is used only for build > (builder/MyBuilder.pm:5). -Requires: perl(parent) Ok > FIX: The package uses bundled source of 'zstd', so you have to added it to > provides. See info: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling +# Unbundling is not possible, because libzstd-devel doesn't not contains +# 'compress/zstdmt_compress.h', which is used by lib/Compress/Stream/Zstd.xs +Provides: bundled(zstd) = 1.4.3 Ok. > TODO: Remove the deleting empty directories in %install section. This is > default behavior for Fedoras. Ignore it for EPEL 7. > TODO: Removing *.bs file could be simplified > find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -delete It can be used in EPEL 7. > TODO: Please consider adding 'eg/' to %doc +%doc Changes README.md eg/ Ok I missed one thing. FIX: Please add build-requires perl-devel and gcc, because it is XS package. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the last 'FIX' item. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011825 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
