https://bugzilla.redhat.com/show_bug.cgi?id=2011825 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jplesnik@xxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL is ok FIX: Please switch source from www.cpan.org to metacpan.org https://cpan.metacpan.org/modules/by-module/Compress/Compress-Stream-Zstd-%{version}.tar.gz All tests passed BuildRequires FIX: Please add build-requires: coreutils - perl-Compress-Stream-Zstd.spec (line 42) findutils - perl-Compress-Stream-Zstd.spec (line 39,40) perl-interpreter - perl-Compress-Stream-Zstd.spec (line 20,33) perl(Config) - builder/MyBuilder.pm:7 perl(Devel::PPPort) - builder/MyBuilder.pm:50 perl(File::Basename) - Build.PL:14 perl(File::Spec) - Build.PL:15 perl(utf8) - Build.PL:10 FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 5.008001' because the package has an epoch. $ rpm -qp --requires perl-Compress-Stream-Zstd-0.202-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.2)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(Compress::Stream::Zstd) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(parent) 1 perl(strict) 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are almost Ok. FIX: Please remove run-require 'perl(parent)'. It is used only for build (builder/MyBuilder.pm:5). $ rpm -qp --provides perl-Compress-Stream-Zstd-0.202-1.fc36.x86_64.rpm | sort | uniq -c 1 perl(Compress::Stream::Zstd) = 0.202 1 perl-Compress-Stream-Zstd = 0.202-1.fc36 1 perl(Compress::Stream::Zstd::CompressionContext) 1 perl(Compress::Stream::Zstd::CompressionDictionary) 1 perl(Compress::Stream::Zstd::Compressor) 1 perl(Compress::Stream::Zstd::DecompressionContext) 1 perl(Compress::Stream::Zstd::DecompressionDictionary) 1 perl(Compress::Stream::Zstd::Decompressor) 1 perl-Compress-Stream-Zstd(x86-64) = 0.202-1.fc36 Binary provides FIX: The package uses bundled source of 'zstd', so you have to added it to provides. See info: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Unbundling is not possible, because libzstd-devel doesn't not contains 'compress/zstdmt_compress.h', which is used by lib/Compress/Stream/Zstd.xs $ rpmlint ./perl-Compress-Stream-Zstd* perl-Compress-Stream-Zstd.src: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Compress-Stream-Zstd.src: W: spelling-error %description -l en_US de -> DE, ed, d perl-Compress-Stream-Zstd.x86_64: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Compress-Stream-Zstd.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras. TODO: Removing *.bs file could be simplified find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -delete TODO: Please consider adding 'eg/' to %doc Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2011825 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
