https://bugzilla.redhat.com/show_bug.cgi?id=2003700 Michal Schorm <mschorm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #19 from Michal Schorm <mschorm@xxxxxxxxxx> --- I've went throught the Python Packaging Guidelines again for this review. I've found just two minor issues, neither which blocks this package to be accepted. This is a quick overview of what I went through: Distro-wide guidelines [OK] Naming [OK] Files to include [OK] Dist-info metadata [OK] Explicit lists [OK] PyPI parity [OK] https://pypi.org/project/container-workflow-tool/ Provides and requirements [OK] The requirements from requirements.txt are listed: # rpm -q --requires container-workflow-tool-1.1.0-1.fc36.noarch.rpm ... python3.10dist(gitpython) python3.10dist(pyyaml) python3.10dist(requests-kerberos) ... Interpreter invocation [OK] Using Cython [OK] Tests [OK] Source files from PyPI [OK] ----- Issue 1) Versioned links During this round of the review, I wanted to compare it with the previous versions of the SPECfile. However, nearly all of the links listed in this BZ now leads to the same version of the SPECfile. I strongly suggest to keep an eye on this issue next time and let the links point to a specific commits, so the history of what has been done is not concealed. Issue 2) Incomplete fix Somewhere during your update from CWT version 1.0.0 to 1.1.0 you forgot to update the SPECfile changelog. The listed date, when you claim you made an update to the 1.1.0-1 version: "Wed Sep 29 2021" is before that version was released by upstream: "OCT-06-2021" https://github.com/sclorg/container-workflow-tool/releases/tag/1.1.0 There was IMO also no need to re-write the SPECfile, instead of patching it. You could have kept the changelog and list everything you fixed in it. This would also partly help with comparing between the older versions of the SPECfile. ----- I _ACCEPT_ this package submission. Zuzana, feel free to contact me anytime, should you need any additional guidance or just a help in the Fedora import/build/update process. Thank you Miro for the help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2003700 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
