https://bugzilla.redhat.com/show_bug.cgi?id=2008090 --- Comment #15 from Andreas Krebbel <krebbel1@xxxxxxxxxx> --- (In reply to Dan Horák from comment #13) > And few more comments from working on the formal review: > - seems there is a space missing in the %description for the static > subpackage - ... of%{name} -> ... of %{name} > - the Requires for the main package in "devel" needs to be "arched" - see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_requiring_base_package > - the "static" subpackage needs to Require the "devel" subpackage, arched > again, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries (the "1. Static libraries and shared libraries" subsection) Thanks for the review. I've fixed these issues and have uploaded a new version. SPEC: https://ankr.fedorapeople.org/libzdnn.spec SRPM: https://ankr.fedorapeople.org/libzdnn-0.3.1-4.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2008090 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure