https://bugzilla.redhat.com/show_bug.cgi?id=2013336 --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- The `%global srcname resalloc-aws` isn't used. Maybe you planned to use it somewhere or forgot to remove it? A few minor grammar errors in the description - "allocating/removing machine" should IMHO be "... a machine" or "... machines" - "(a) start the machine" should IMHO be "start a machine" - "removes the machine started" should IMHO also be "a machine" In the %install section there is a couple of macros used as %foo while the rest of the spec uses %{foo}. This inconsistency is AFAIK pretty common, so I don't mind it very much but this I don't like mkdir -p %buildroot%_bindir Please use %{buildroot}%{_bindir} or / as a separator. This would maybe fit better a %setup phase instead of a %install phase? sed '1c#! /usr/bin/python3' -i %buildroot/%_bindir/resalloc-aws-wait-for-ssh Also, maybe it would be better to use %{__python3} instead of /usr/bin/python3 directly, in case the path changes in the future? In the %files section, I would rather be more specific than %{_bindir}/%{name}-* in case somebody provided additional commands in another package. It's very unlikely but the change is trivial. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013336 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
