https://bugzilla.redhat.com/show_bug.cgi?id=2012522 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |pikachu.2014@xxxxxxxxx --- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Hello, thanks for packaging yt-dlp. Since I'm just a packager and not a sponsor, the following review is *informal*. The SPEC file looks quite good. Suggests and Supplements clauses are wisely used and the package mainly follows the latest Python packaging guidelines. Here are a few suggestions: * you should use the %py3_dist macro for explicit Python dependencies, for example %{py3_dist keyring} instead of python3-keyring. This makes dependency tracking easier, based on PyPi names. This may be useful also in case of naming convention changes for Python packages. * Why not using %tox for tests in %check section, instead of an explicit call to %pytest (and the corresponding BuildRequires)? The project provides a Tox test suite and it's well supported by the Python packaging scheme (BTW you are generating BRs with "%pyproject_buildrequires -t"). You can pass Pytest options to tox using the PYTEST_ADDOPTS variable: %check export PYTEST_ADDOPTS="-k 'not download'" %tox * Since mutagen is already required by the package (automatically added as Requires from setup.py), the Suggests on AtomicParsley is probably useless. * according to rpmlint, some Python files contain shebangs whereas they're not executable: yt-dlp.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py 644 /usr/bin/env python3 yt-dlp.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/yt_dlp/__init__.py 644 /usr/bin/env python3 yt-dlp.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/yt_dlp/__main__.py 644 /usr/bin/env python3 yt-dlp.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/yt_dlp/utils.py 644 /usr/bin/env python3 You can use for example https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries to fix this, while keeping file timestamp. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2012522 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
