[Bug 2000219] Review Request: llvm-libunwind - LLVM libunwind implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2000219

mkulik@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mkulik@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #11 from mkulik@xxxxxxxxxx ---
Few things:

- You decided to change default directory because of a conflict. You should
apply those changes to doc subpackage too.
  Your package will put documentation in the same directory as (already
present) libunwind.
  doc package main directory is: /usr/share/doc/libunwind
  main package directory: /usr/lib64/llvm-unwind
- devel subpackage contains shared libraries and static ones.
  This is not allowed according to guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries
- Typo in License in doc subpackage '(' ?
  also other packages:
  llvm-libunwind.x86_64: W: invalid-license-exception exceptions
  llvm-libunwind.x86_64: W: invalid-license 2.0
- Both packages provides libunwind.so.X (yours ans libunwind's)
  I would check if everything is according to guidelines here:
 
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
  Adding note, explanation (fixes if necessary) regarding this would be a good
idea.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2000219
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux