https://bugzilla.redhat.com/show_bug.cgi?id=2005122 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Flags| |needinfo?(sanjay.ankur@gmai | |l.com) --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I was going to find the commit corresponding to the PyPI tarball, even though upstream did not tag it, and suggest using that for the tests—but there isn’t one! The actual package sources (i.e., lazy_ops/ directory) match https://github.com/catalystneuro/lazy_ops/commit/407504d1c4b1447e9527e7bddd771b6cc6f4810a, but setup.py is not updated for 0.2.0 in that commit. In the next commit, the version is 0.2.1, which is newer than any PyPI release, and there are additional changes in lazy_ops/. ----- I guess something still has to be done, because there is no license file in the PyPI tarball, and the BSD license requires the license/copyright text to be reproduced (https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text). The more aggressive option would be to combine the GitHub tarball for commit 407504d1c4b1447e9527e7bddd771b6cc6f4810a with the PyPI 0.2.0 release tarball, using only the setup.py from the latter. That would give you the license file *and* let you run the tests. Or, you could keep the PyPI tarball as you have it, and add https://github.com/catalystneuro/lazy_ops/raw/407504d1c4b1447e9527e7bddd771b6cc6f4810a/LICENSE as an additional source, still forgoing the tests. What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2005122 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
