https://bugzilla.redhat.com/show_bug.cgi?id=2011908 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Some preliminary notes: - It would be great to package this under the new Python guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/), using pyproject-rpm-macros. - You can’t bundle font files (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_avoid_bundling_of_fonts_in_other_packages). You’ll have to figure out how to get https://src.fedoraproject.org/rpms/fontawesome5-fonts to provide the necessary fonts in OpenType format according to https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ and then patch pywaffle to use the system-wide versions. This is a huge pain, but there isn’t really any way around it. - Your Summary should be shortened to less than 80 characters. - You should remove shebang lines from pywaffle/*.py, since they are not executable and not suitable for use as scripts. Preferably, send a patch or PR upstream for this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011908 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
