https://bugzilla.redhat.com/show_bug.cgi?id=2009214 --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Sandro Mani from comment #5) > Sorry, took me a while to get to this. No problem. I'm in no hurry at all. :-) One issue in comment 4 has not been addressed, namely: - Is there a bug about the s390x exclusion? It should be noted in a comment above the ExcludeArch tag. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures Also, I'm still not sure the license is correct. The tools aren't packaged, right? Just the libraries? So then shouldn't the license be: (GPLv2+ or LGPLv3) and MIT and BSD and Boost ? That's what I get from dist/changes-5.7.0, and it seems to match the header of various source files. For example, picking one at random, see the top of src/positioningquick/qpositioningquickglobal_p.h. The license exception seems to be for the tools only, not for the libraries, the GPL version is 2 or later, not 3, and the LGPL version is 3, not 2. See also the license field in conanfile.py. The "GPLv3 with exceptions" license seems to apply only to files under config.tests. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2009214 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
