https://bugzilla.redhat.com/show_bug.cgi?id=2010688 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL is ok FIX: Please switch source from search.cpan.org to metacpan.org https://cpan.metacpan.org/authors/id/F/FA/FANGLY/Math-Random-MT-%{version}.tar.gz All tests passed FIX: Please add following build-requires: perl(Carp) - MT.pm:4 perl(DynaLoader) - MT.pm:5 perl(strict) - MT.pm:3 perl(vars) - MT.pm:6 perl(Benchmark) - t/9.t:3 $ rpm -qp --requires perl-Math-Random-MT-1.17-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libperl.so.5.34()(64bit) 1 perl(Carp) 1 perl(DynaLoader) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(strict) 1 perl(vars) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Math-Random-MT-1.17-1.fc36.x86_64.rpm | sort | uniq -c 1 perl(Math::Random::MT) = 1.17 1 perl-Math-Random-MT = 1.17-1.fc36 1 perl-Math-Random-MT(x86-64) = 1.17-1.fc36 Binary provides are Ok. $ rpmlint ./perl-Math-Random-MT* perl-Math-Random-MT.src: W: spelling-error %description -l en_US pseudorandom -> pseudo random, pseudo-random, pseudonymous perl-Math-Random-MT.src: W: spelling-error %description -l en_US www -> WWW, wow perl-Math-Random-MT.src: W: spelling-error %description -l en_US keio -> keno perl-Math-Random-MT.src: W: spelling-error %description -l en_US jp -> JP, dip, hp perl-Math-Random-MT.src: W: spelling-error %description -l en_US nisimura -> simulacra perl-Math-Random-MT.src: W: spelling-error %description -l en_US ps -> PS, pa, pd perl-Math-Random-MT.src: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US pseudorandom -> pseudo random, pseudo-random, pseudonymous perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US www -> WWW, wow perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US keio -> keno perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US jp -> JP, dip, hp perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US nisimura -> simulacra perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US ps -> PS, pa, pd perl-Math-Random-MT.x86_64: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling 2 packages and 1 specfiles checked; 0 errors, 14 warnings. Rpmlint is ok FIX: Please remove obsolete Group tag FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to 6.76 or higher, because NO_PACKLIST option was added in this version. TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras. TODO: Removing *.bs file could be simplyfied find %{buildroot} -type f -name '*.bs' -empty -delete Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010688 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
