https://bugzilla.redhat.com/show_bug.cgi?id=2010999 Michael Catanzaro <mcatanza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcatanza@xxxxxxxxxx --- Comment #1 from Michael Catanzaro <mcatanza@xxxxxxxxxx> --- This is not a full review, but a preliminary one: Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/help/C/gnome-text-editor But I think this is a bug in fedora-review, since this is a directory, not a file. So... I think you can ignore this one. - I think all four of the runtime Requires are unnecessary. These should all be handled automatically via autogenerated .so deps. - I've never understood the directory ownership rules. Maybe we have to own or require other packages to own these dirs? Note: Directories without known owners: /usr/share/help/C, /usr/share/dbus-1, /usr/share/dbus-1/services -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2010999 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
