https://bugzilla.redhat.com/show_bug.cgi?id=2007791 --- Comment #5 from Didik Supriadi <didiksupriadi41@xxxxxxxxx> --- (In reply to Raphael Groner from comment #3) > Try to run provided test suite for ECMAScript in %check. > > https://github.com/tc39/test262/tree/f94fc660cc3c59b1f2f9f122fc4d44b4434b935c I'd see if I could manage to run this test because I had to convert things to maven. > In %files can you be more specific instead of just wildcards similiar as > done for %doc with .md? > > > %{_bindir}/* > > %{_mandir}/man1/* Yes, I could do that instead. > Why not use gradle as upstream recommends, instead of maven with downstream > patch? gradle has been long dead [1] and it's not possible to package. I had to convert rhino to maven somehow. (In reply to Raphael Groner from comment #4) > I'd also suggest to ship examples/ in %doc . > > For %check, execution of tests is explained: > https://github.com/mozilla/rhino/blob/master/testsrc/README.md rhino only includes rhino-engine and rhino-runtime in maven central. I'm afraid I could not do that. Usually, I have to check jars that I produce is compatible with jars in maven central. [1] https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/BMJXGWKXXFOOBQON3XFYPFBOWEZMAKKU/ [2] https://repo1.maven.org/maven2/org/mozilla/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2007791 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
