https://bugzilla.redhat.com/show_bug.cgi?id=2010409 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Since this was already approved, some further comments (I'm coming from https://pagure.io/releng/issue/10325#comment-754577): MUSTs: 0) validate the metainfo.xml file -- see https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage Suggestions (all optional): 1) if you intend to build this in F35 and not just rawhide, you will need to bump the release, as the current version-release has already been built once in Koji 2) make -> %make_build 3) make install -> %make_install 4) cp metainfo.xml -> cp -p metainfo.xml (to preserve the timestamp) 5) don't mix ${RPM_BUILD_ROOT} with %{buildroot} in one spec file (I'd say %{buildroot} is more common in "nowadays" packages) 6) %files ... %{_datadir}/icebreaker -> consider using %{_datadir}/icebreaker/ to indicate this is a directory, to make it easier for the reader of the spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010409 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
