[Bug 2008090] Review Request: libzdnn - IBM Z specific hardware exploitation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2008090



--- Comment #7 from Andreas Krebbel <krebbel1@xxxxxxxxxx> ---
(In reply to Dan Horák from comment #5)
> I think the passing of -march=z14 will need some thinking, because I see 2
> kinds of gcc command lines
> 
> gcc -O3 -march=z14 -mzvector -Wall -std=gnu99 -fstack-protector-all -O2
> -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64
> -march=zEC12 -mtune=z13 -fasynchronous-unwind-tables
> -fstack-clash-protection -march=z14 -funroll-loops "-Wall" -I ../zdnn -I .
> -fPIC  -c init_ztensor.c -o obj/init_ztensor.o
> 
> and 
> 
> gcc -O3 -mzvector -Wall -std=gnu99 -fstack-protector-all -O2 -flto=auto
> -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=zEC12 -mtune=z13
> -fasynchronous-unwind-tables -fstack-clash-protection -march=z14 "-Wall"
> -fPIC  -c zdnn_init.c -o obj/zdnn_init.o
> 
> The first one has -march=z14 twice, the second has one occurrence. The
> "appended" -march overrides the distro wide flags, which is OK in the first
> case,  I think, but not in the second ...

Good catch. The second must not have an -march=z14. I've added a patch to the
srpm and pass CFLAGS_INIT to configure as well now. There I do not append
-march=z14. The build command lines look ok with that change. Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2008090
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux