https://bugzilla.redhat.com/show_bug.cgi?id=2009666 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > %define ver 3.0 > %define rel 1 These aren't used anywhere apart from the Version and Release tags. You can just put those values straight into the tags. > Release: %{rel} Missing disttag, i.e. "value" -> "value%{?dist}". > Group: Applications/Productivity Not used in Fedora. > %clean Not used in Fedora. > %prep > rm -rf $RPM_BUILD_ROOT Guidelines say that the buildroot should not be removed in %install. This is done in %prep, so I guess *technically* it's okay, but still, there's no need to do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > License: GPL The program seems to be GPL 2.0 only, which means a License tag of "GPLv2". https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses > %files > %defattr(-,root,root) Not needed. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions > %doc README COPYING doc/manual_en.html COPYING should be marked as %license. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2009666 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
