[Bug 2003700] Review Request: container-workflow-tool - Tool for automation of rebuilding container images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2003700



--- Comment #15 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Some more feedback on the current spec file:


> Provides:       python%{python3_pkgversion}-%{name}


Whenever you provide an "alternative package name" like this, always include
the version:

  Provides:       python%{python3_pkgversion}-%{name} =
%{?epoch:%{epoch}:}%{version}-%{release}

However, if the name starts with "python3-" you can just use "%py_provides
python%{python3_pkgversion}-%{name}" which does this for you:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules


------------


# man installation change was proposed on upstream:
# https://github.com/sclorg/container-workflow-tool/pull/43
# if this PR is merged, the following lines can be removed

I don't understand that comment. The manual man page installation should stay
when this is merged, no?



------

%files ...
%{_mandir}/man1/cwt.1.gz

You should not assume the suffix is gz. Based on some macros setup, it could
change in the future. Usea glob like this instead:

%{_mandir}/man1/cwt.1*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2003700
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux