https://bugzilla.redhat.com/show_bug.cgi?id=2008153 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks very good. A few fixes needed before we can approve it. Please make the fixes, and then upload the updated spec/srpm and provide there links and then we'll do another round of review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ^ Your release should either be %autorelease, or 1%{?dist}. The dist tag is mandatory: https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ - Hrm, licensecheck reports that two files are GPLv3, not GPLv3+, so I guess we should go back to GPLv3 here. - Upstream does not ship a desktop file, so we should add one and send it upstream - (optional, but good to have) Upstream does not include a appstream metainfo file, so we should add one and send it upstream too. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - some rpmlint warnings need to be fixed (see below) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "GNU General Public License, Version 3", "*No copyright* [generated file]". 48 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2008153-pyplane/licensecheck.txt ^ Two files are GPLv3, not GPLv3+, so we should go back to GPLv3 (which you'd initially used). [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Package contains desktop file if it is a GUI application. ^ I see upstream does not ship a desktop file. We should write one and send it upstream: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [!]: Package complies to the Packaging Guidelines ^ Some notes [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. ^ Not tested this yet. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- rpmlint *rpm ../srpm-unpacked/* checks: 31, packages: 4 pyplane.spec:37: W: unversioned-explicit-provides python3-pyplane pyplane.spec:37: W: unversioned-explicit-provides python3-pyplane pyplane.noarch: W: no-manual-page-for-binary pyplane pyplane.spec:68: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 68) pyplane.spec:68: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 68) ^ tab at the end of the changelog line pyplane.noarch: W: incoherent-version-in-changelog 2.0.0-1 ['2.0.0-1', '2.0.0-1'] ^ I think the changelog issue is because of the missing dist-tag Source checksums ---------------- https://github.com/TUD-RST/pyplane/archive/PyPlane_v2.0.0/pyplane-PyPlane_v2.0.0.tar.gz : CHECKSUM(SHA256) this package : e860febb008f69bb82dff9c29610d9967335f812f485eaec57923d282cfd1f93 CHECKSUM(SHA256) upstream package : e860febb008f69bb82dff9c29610d9967335f812f485eaec57923d282cfd1f93 Requires -------- pyplane (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.10dist(matplotlib) python3.10dist(numpy) python3.10dist(pyqt5) python3.10dist(scipy) python3.10dist(sympy) Provides -------- pyplane: pyplane python3-pyplane python3.10dist(pyplane) python3dist(pyplane) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2008153 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, Ocaml, Haskell, Java, fonts, R, Perl, PHP, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2008153 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
