https://bugzilla.redhat.com/show_bug.cgi?id=2005752 --- Comment #4 from mkulik@xxxxxxxxxx --- No problem, here are few things that should be addressed after deeper look at package. * You got one typo in changelog: "- Wed Sep 24 2021 Hirotaka Wakabayashi (bogus date)" * Package provides some extra_requires that are optional. Maybe it's worth to check if (ZSTD, LZ4, snappy..) are correctly added, more info: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras I'm not sure if all extras should be included (testing usage), maybe none of them should be included. Investigate, fix or just make a comment regarding this. * I would generate additional docs (maybe pdf ?). Upstream uses sphinx so it should be easy. What also caught my eye is that you are using .diff for patch files. This is probably fine and correct but usually in other packages: python and not python ones .patch extensions is used. This is probably matter of preference so it's fine. Overall, good job. I will finish review after above issues are fixed/addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2005752 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
