https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #113 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Warren Togami from comment #81) > > There exists a corner case where "stop" can take significantly more time > > than any amount hardcoded here. Force kill in that situation causes data > > corruption and an even more time consuming recovery the next time indexing > > begins again. I asked my engineers here if they came up with a better way to > > detect a safe stop. > > TimeoutStopSec=1200s This is way too big. In the case of a shutdown/reboot of a system, all the units depending on network will shut off and then basically there will be the network up and bitcoin trying to stop for 20 minutes. Assuming you reach that point, you would wait with a pingable only host that is trying to reboot for 20 minutes. I think it's much more reasonable to have a shorter timeout, and in corner cases where you need more, you can just edit the systemd override configuration with what you need (systemctl edit bitcoin). > Restart=always This is wrong, it should be "on-failure". If I run "bitcoin-cli stop" then the daemon would just restart endlessly. If I shut it down correctly it should not come up again, only in case of failures. Again, like above, you can tune it for specific cases. > # Fail when 10 tries within 1 minute fail (never) > StartLimitInterval=60s > StartLimitBurst=10 > # Limit attempts to 1 per 10 seconds > Restart=always > RestartSec=10 This is as well wrong. You're basically allowing it to restart once maximum every 10 seconds and then you check if it fails 10 times in one minute, which is an impossible condition. Combined with the above restart always you make the daemon restart in a loop even in case of issues. This is definitely not a sane configuration, might work in your case but should not be shipped as the default. I'm not changing the parameters here. On a side note, now that RHEL/CentOS 7 is no longer a target, I have now added more hardening to the systemd unit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1834731 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
