https://bugzilla.redhat.com/show_bug.cgi?id=1997278 --- Comment #15 from Mat Booth <mat.booth@xxxxxxxxx> --- Nice work so far :-) I just see some more things I think should be fixed: Line 3: %global eclipse_tag S-%{eclipse_rel}-202109060500 Should be: %global eclipse_tag R-%{eclipse_rel}-202109060500 (This shuts up rpmlint invalid Source0 URL errors) Line 30: You don't need explicit "R gtk3" since a requires should be auto-generated on libgtk-3.so.0 Line 31: Don't "R webkitgtk4" -- this package is obsoleted by webkit2gtk3, so use "R webkit2gtk3" instead. Line 40: You don't need "BR gtk2-devel" if you're building gtk3 bindings only. Line 48: You still have this section: %ifarch s390x %global eclipse_arch x86_64 %endif Don't change the arch to something that is incorrect, the correct arch for s390x is "s390x" so you can remove this. Did you know you can use "%javadoc_package" and "%mvn_install" macros to auto-generate the javadoc subpackage? You can remove a bunch of stuff from this spec file: Replace lines 57-61 (the whole subpackage definition) with one line macro: %javadoc_package Then on line 133, tell "%mvn_install" where the javadoc is using -J flag, e.g.: %mvn_install -J %{swtsrcdir}/docs/api/ Then you can delete lines 138 and 139 (creating dir and copying javadoc into place) and you can delete lines 148-151 (the whole "%files javadoc" section) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1997278 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
