https://bugzilla.redhat.com/show_bug.cgi?id=2006997 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me now. You didn't have to include a separate changelog entry for this small change :) ============= Final review: Simplified review, because this is a standard Rust package that was generated with rust2rpm. - package builds successfully on rawhide (see koji scratch build) - test suite is run and all unit tests pass (there are no tests in this crate) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora (ASL 2.0 with exceptions) - license file has been submitted upstream and is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. Please don't forget to also request f35 and f34 branches for your package. (Pro tip: You can do that before the repository exists by using the "--repo" flag for "fedpkg request-branch, since these requests are processed chronologically. So this works fine so long as you request the repository first, and any branches second. This reduces the waiting time from two to one round-trip-time with the fedora-scm-requests ticket queue.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2006997 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
