https://bugzilla.redhat.com/show_bug.cgi?id=2006997 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I'll take this review. Package looks good (generated with rust2rpm without modifications), but there's one blocking issue (from my point of view): The crate uses a nonstandard license (Apache-2.0 WITH LLVM-Excpetion), for which we'd need to have the actual license text included in published crates, and then included in the `-devel` subpackage of this crate with "%license". (Even if the project used the standard Apache-2.0 license, including the license text with redistributed sources is *mandatory* according to the license terms. So upstream technically isn't even in compliance with the terms of their own chosen license, since they publish and redistribute it via crates.io *without* the license text ...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2006997 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
