https://bugzilla.redhat.com/show_bug.cgi?id=2000219 mkulik@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkulik@xxxxxxxxxx --- Comment #7 from mkulik@xxxxxxxxxx --- Hi, Few minor, cosmetic things that I noticed: - Documentation in -doc package provides HTML style documentations. This type of docs usually include bunch of .js libraries whose licenses should be included in SPEC file. For example doctools.js is provided using BSD license. - %{_libdir}/llvm-unwind directory seems to be own by main and a devel package, that's probably not necessary in your example. The devel package is dependent on main package so llvm-unwind directory will always be own by main package. I would drop this line: %dir %{_libdir}/llvm-unwind from devel package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2000219 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure