Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MooseX-AttributeHelpers - Extended Moose attribute interfaces https://bugzilla.redhat.com/show_bug.cgi?id=399171 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-26 06:30 EST ------- oops its already in rawhide. I missed rawhide updates to my local mock repo. Here comes now Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c4a9f6cdc106c6bf9a330d7f20c5fdd4 MooseX-AttributeHelpers-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/000_load.....................ok t/001_basic_counter............ok t/002_basic_array..............ok t/003_basic_hash...............ok t/004_basic_number.............ok t/005_basic_list...............ok t/006_basic_bag................ok t/010_array_from_role..........ok t/011_counter_with_defaults....ok t/100_collection_with_roles....ok t/pod..........................ok t/pod_coverage.................ok All tests successful. Files=12, Tests=224, 18 wallclock secs (12.38 cusr + 0.38 csys = 12.76 CPU) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review