https://bugzilla.redhat.com/show_bug.cgi?id=2001699 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok TODO: Move 'perl(Test::TCP)' from runtime BR to test BR $ rpm -qp --requires perl-Web-Machine-0.17-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(B) 1 perl(Carp) 1 perl(Encode) 1 perl(Hash::MultiValue) 1 perl(HTTP::Headers::ActionPack) >= 0.07 1 perl(HTTP::Status) 1 perl(IO::Handle::Util) 1 perl(List::Util) 1 perl(Locale::Maketext) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Module::Runtime) 1 perl(parent) 1 perl(Plack::Component) 1 perl(Plack::Request) 1 perl(Plack::Response) 1 perl(Plack::Util) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Exporter) 1 perl(Try::Tiny) 1 perl(warnings) 1 perl(Web::Machine::FSM) 1 perl(Web::Machine::FSM::States) 1 perl(Web::Machine::I18N) 1 perl(Web::Machine::Util) 1 perl(Web::Machine::Util::BodyEncoding) 1 perl(Web::Machine::Util::ContentNegotiation) Binary requires are Ok. $ rpm -qp --provides perl-Web-Machine-0.17-1.fc36.noarch.rpm | sort | uniq -c 1 perl(Web::Machine) = 0.17 1 perl-Web-Machine = 0.17-1.fc36 1 perl(Web::Machine::FSM) = 0.17 1 perl(Web::Machine::FSM::States) = 0.17 1 perl(Web::Machine::I18N) = 0.17 1 perl(Web::Machine::I18N::en) = 0.17 1 perl(Web::Machine::Resource) = 0.17 1 perl(Web::Machine::Util) = 0.17 1 perl(Web::Machine::Util::BodyEncoding) = 0.17 1 perl(Web::Machine::Util::ContentNegotiation) = 0.17 Binary provides are Ok. $ rpmlint ./perl-Web-Machine* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Build failed with an error: Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/perl-Web-Machine-0.17-1.fc36.x86_64 error: Installed (but unpackaged) file(s) found: /usr/lib64/perl5/perllocal.pod /usr/lib64/perl5/vendor_perl/auto/Web/Machine/.packlist Installed (but unpackaged) file(s) found: /usr/lib64/perl5/perllocal.pod /usr/lib64/perl5/vendor_perl/auto/Web/Machine/.packlist FIX: Please add to command 'perl Makefile.PL' options 'NO_PACKLIST=1 NO_PERLLOCAL=1' Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' item, consider fixing 'TODO' item. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2001699 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
