https://bugzilla.redhat.com/show_bug.cgi?id=2003876 --- Comment #7 from Matt Domsch <matt@xxxxxxxxxx> --- Petr, sincere thanks for the package review. I've updated the package per your comments. - As you note, upstream imgui has no build system, they fully expect and encourage consumers to bundle their code directly. As such I leave imgui bundled. - License field fixed, a copy of the MIT license for Discourse was found in the source and added to %license. - %doc files added as requested. - Font removed, uses google-roboto-fonts directly now - Further comments added regarding sending patches upstream. Upstream has a ticket open discussing reworking the whole cmake build system, which includes extracting bundled libraries into their own directories to make it easier to spot and include/not include based on system availability. I've chimed into that thread regarding the changes necessary to be acceptable to Fedora. https://github.com/AlexandreRouma/SDRPlusPlus/issues/292 - I found another imgui-bundled library stb_truetype which is identical to the available unbundled library, so that has now been removed. Two other stb-sourced files are effectively imgui private forks at this point, so they remain in the bundled imgui library. - licensecheck reports quite a few additional licenses but most are in the libsddc which is present in the source but not built (upstream is not ready for it to be distributed by default). - licensecheck did show that discord-rpc is bundled (MIT license), added to the bundled list. This library is deprecated by upstream in favor of the Discord GameSDK, so it should not be bundled into Fedora separately. - I have run this on my local system with RTL-SDR hardware attached to my radio, and it behaves as expected. Updated spec: https://domsch.com/fedora/sdrpp/fedora-rawhide-x86_64/sdrpp.spec Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=75919275 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2003876 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
