Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NoGravity - 3D 'Wing Commander'-like game https://bugzilla.redhat.com/show_bug.cgi?id=366841 ------- Additional Comments From lemenkov@xxxxxxxxx 2007-11-26 05:29 EST ------- (In reply to comment #2) > This is a pre-review as part of my own quest for sponsorship, so don't take > too much notice, but here goes: > > In the spec file: > > o Consider using dist tag (http://fedoraproject.org/wiki/Packaging/DistTag) > o Redundant BuildRequires SDL-devel and libogg-devel (already brought in by > SDL_mixel-devel and libvorbis-devel respectively) > o Missing BuildRequires, at least aclocal for the bootstrap script (mock > nogravity-2.00-1.src.rpm fails) > o Avoid %makeinstall or comment as to why it's necessary (see > http://fedoraproject.org/wiki/Packaging/Guidelines) > o Consider installing icon pixmaps under %_datadir/icons/hicolor/??x??/apps > and calling gtk-update-icon-cache, as per the section "GTK+ icon cache" of > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets > o rpmlint nogravity-2.00-1.src.rpm > nogravity.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) > nogravity.src: W: strange-permission nogravity--bootstrap 0755 > o rpmlint nogravity-2.00-1.i386.rpm > nogravity.i386: W: > wrong-file-end-of-line-encoding /usr/share/doc/nogravity-2.00/GNU.TXT > nogravity.i386: W: > wrong-file-end-of-line-encoding /usr/share/doc/nogravity-2.00/README.TXT > o rpmlint nogravity-data-2.00-1.i386.rpm > nogravity-data.i386: W: no-documentation > o Should the game binary package Require: the data package as a dependency? > o Data directory needs owner (%dir directive in %files) > o Spelling mistake Necesssary in %package data > > Apart from that, it builds and runs fine on my desktop. OK, updated: http://peter.fedorapeople.org/nogravity.spec http://peter.fedorapeople.org/nogravity-2.00-2.fc8.src.rpm I'll split this package and add Hans's patch asap. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review