https://bugzilla.redhat.com/show_bug.cgi?id=1998886 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-liblarch See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names The above warning is from fedora-review. That's okay. This is deliberate. You'll have to be sure to follow the steps here, though: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming - Consider using a Source0 URL that gives the tarball a name, as described here: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags In this case, something like this would do: Source0: https://github.com/getting-things-gnome/liblarch/archive/v%{version}/liblarch-%{version}.tar.gz - You are strongly encouraged to use the package name python3-liblarch-gtk (with a dash) instead of python3-liblarch_gtk (with an underscore). This is not a requirement, but is strongly encouraged. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_separators - The Requires in the python3-liblarch_gtk subpackage should read: Requires: python3-liblarch = %{version}-%{release} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package - Fedora has a python3-gobject-base package, which is all of pygobject except the cairo interface. This package doesn't seem to need the cairo part, so I think the BuildRequires and Requires of python3-gobject can probably both be changed to python3-gobject-base. Can you try that and see? Incidentally, that's why I suggested a BuildRequires of %{py3_dist pygobject}, which resolves to python3-gobject-base. - The python3-liblarch and python3-liblarch_gtk packages both contain each other's files. The issue is that there is a single %pyproject_save_files invocation for both modules, so they get the same file lists via -f %{pyproject_files}. - The python3-liblarch_gtk package is missing some dependency. If I install it into an empty mock chroot and try to import it, I get this: $ python3 Python 3.10.0rc2 (default, Sep 8 2021, 00:00:00) [GCC 11.2.1 20210728 (Red Hat 11.2.1-1)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import liblarch_gtk Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.10/site-packages/liblarch_gtk/__init__.py", line 21, in <module> gi.require_version("Gtk", "3.0") # noqa File "/usr/lib64/python3.10/site-packages/gi/__init__.py", line 126, in require_version raise ValueError('Namespace %s not available' % namespace) ValueError: Namespace Gtk not available If I install the gtk3 package into the mock chroot and try again, I get a connection error. If I run "xvfb-run -d python3" and then import liblarch_gtk, that works. Bottom line: I think python3-liblarch_gtk should have Requires: gtk3. This makes me wonder if BuildRequires: gtk3 is sufficient, instead of requiring gtk3-devel. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3", "GNU Lesser General Public License v3.0 or later", "*No copyright* GNU Lesser General Public License, Version 3". 17 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 11 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-liblarch , python3-liblarch_gtk [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-liblarch-3.1.0-1.fc36.noarch.rpm python3-liblarch_gtk-3.1.0-1.fc36.noarch.rpm python-liblarch-3.1.0-1.fc36.src.rpm python3-liblarch.noarch: W: spelling-error %description -l en_US acyclic -> cyclic, a cyclic, acyclovir python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) Liblarch -> Lib larch, Lib-larch, Oligarch python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) gtk -> gt, gt k python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) Treeview -> Tree view, Tree-view, Preview python3-liblarch_gtk.noarch: W: spelling-error %description -l en_US gtk -> gt, gt k python3-liblarch_gtk.noarch: W: spelling-error %description -l en_US Treeview -> Tree view, Tree-view, Preview python-liblarch.src: W: spelling-error %description -l en_US acyclic -> cyclic, a cyclic, acyclovir 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- ================================================ rpmlint session starts ================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 ================= 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ================= Source checksums ---------------- https://github.com/getting-things-gnome/liblarch/archive/refs/tags/v3.1.0.tar.gz : CHECKSUM(SHA256) this package : 8542f51bde7a064fe81556ee34acfb124bd783e9c4e8826ca1b07445cdde5690 CHECKSUM(SHA256) upstream package : 8542f51bde7a064fe81556ee34acfb124bd783e9c4e8826ca1b07445cdde5690 Requires -------- python3-liblarch (rpmlib, GLIBC filtered): python(abi) python3-gobject python3-liblarch_gtk (rpmlib, GLIBC filtered): python(abi) python3-liblarch Provides -------- python3-liblarch: python-liblarch python3-liblarch python3.10-liblarch python3.10dist(liblarch) python3dist(liblarch) python3-liblarch_gtk: python-liblarch_gtk python3-liblarch_gtk python3.10-liblarch_gtk python3.10dist(liblarch) python3dist(liblarch) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1998886 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Perl, R, Java, Haskell, fonts, Ocaml, SugarActivity, PHP, Ruby, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1998886 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
