https://bugzilla.redhat.com/show_bug.cgi?id=1969450 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@xxxxxxxxx | |) | --- Comment #12 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- L almost GTM > Additionally, the uncompiled/unminified version MUST be included alongside the compiled/minified version. That's intended for library JS I believe, like creating a jquery library package, not for shipping what is effectively a website. The whole https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript is for distributing javascript libraries packages. > - You need > > BuildRequires: nodejs-devel > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_buildrequires > Ok > - You need > > ExclusiveArch: %{nodejs_arches} noarch > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_exclusivearch > > (Technically, since your package is noarch and does not use nodejs at > runtime, it could work on an architecture without nodejs support as long as > it is *built* on one with it. I am not sure if there is a viable workaround > for that, though. In practice this still allows all of Fedora’s primary > architectures.) This is still needed because it limits the build to nodejs supported arches. > - If the source tarballs are not URLs, you must document how to re-generate > them; for example, in a spec file comment or by including a script as an > additional Source. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ This need to be fixed, You could use a Github URL for the first tarball, and then detail how you generate the seconnd tarball in a comment. - Unzip this before you install it with %license: dist/index.js.LICENSE.txt.gz - The package.json deps can be used to know which bundled Provides to add -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1969450 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
