https://bugzilla.redhat.com/show_bug.cgi?id=1997994 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- A few comments, based on a quick look at the spec file. I didn’t try to build it or run fedora-review. ---- Runtime dependencies due to shared library linking are automatically generated. You should not need lines like: > Requires: libsodium >= 1.0.18 You might still need those that provide command-line tools or other resources. ---- Versioned dependencies are discouraged when the previous three Fedora releases would satisfy the dependency, i.e.: > BuildRequires: libcurl-devel >= 7.29 should be > BuildRequires: libcurl-devel after consulting https://src.fedoraproject.org/rpms/curl. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies. ---- You can more cleanly write > %package -n oidc-agent-cli as > %package cli and so on. ---- You should use the %make_build and %make_install macros. ---- You should remove > %defattr(-,root,root,-) per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions. ---- You shouldn’t package static libraries without a strong justification: > %{_libdir}/liboidc-agent.a https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries ---- You mustn’t assume gzip compression for man pages (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages). ---- Do you have a reason for using %config instead of %config(noreplace)? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1997994 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
