https://bugzilla.redhat.com/show_bug.cgi?id=1497482 --- Comment #27 from Petr Menšík <pemensik@xxxxxxxxxx> --- Yes, it would be nice to update spec file in upstream to match our spec. If other RPM distributions choose to package dnsviz, they should have available spec without known issues. I think tests should be tweaked a bit to be easier to run. For example, if they had test_ prefix or _test.py suffix, they would be detected by pytest and all of them run automagically. I made pull request with some changes required by pytest [1]. It does not solve failures on mockbuild, where no resolv.conf nameservers are available. It could not directly be used by the package without more tweaks, but I think pytest and %pytest macro would be useful for running tests once it is fixed. I think about dnsviz.config, whether the current situation is sufficient. /usr/share/dnsviz/trusted-keys/root.txt seems like configuration file, which should not be overwritten on upgrade in case of user-made changes. It would be always overwritten without asking in current package state. Similar issue is with /usr/share/dnsviz/hints/named.root, if it needs to be modified. But that would require more code changes, probably move to /etc/dnsviz/named.root or similar path for config files. It would be nice if dnsviz/config were made during normal build phase, so %py3_install macro could be used. I am not sure what would be better way however. 1. https://github.com/dnsviz/dnsviz/pull/87 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1497482 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
