https://bugzilla.redhat.com/show_bug.cgi?id=1997378 Michal Schorm <mschorm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Michal Schorm <mschorm@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pg_auto_failover-1.6.2-1.fc36.x86_64.rpm pg_auto_failover-docs-1.6.2-1.fc36.noarch.rpm pg_auto_failover-llvmjit-1.6.2-1.fc36.x86_64.rpm pg_auto_failover-debuginfo-1.6.2-1.fc36.x86_64.rpm pg_auto_failover-debugsource-1.6.2-1.fc36.x86_64.rpm pg_auto_failover-1.6.2-1.fc36.src.rpm pg_auto_failover.x86_64: W: spelling-error Summary(en_US) Postgres -> Postures, Postgraduates pg_auto_failover.x86_64: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover.x86_64: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover.x86_64: W: spelling-error %description -l en_US autoctl -> autoclave pg_auto_failover-docs.noarch: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover-docs.noarch: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover-llvmjit.x86_64: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover-llvmjit.x86_64: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover-llvmjit.x86_64: W: only-non-binary-in-usr-lib pg_auto_failover-llvmjit.x86_64: W: no-documentation pg_auto_failover-debuginfo.x86_64: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover-debuginfo.x86_64: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover-debugsource.x86_64: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover-debugsource.x86_64: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover.src: W: spelling-error Summary(en_US) Postgres -> Postures, Postgraduates pg_auto_failover.src: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover.src: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover pg_auto_failover.src: W: spelling-error %description -l en_US autoctl -> autoclave 6 packages and 0 specfiles checked; 0 errors, 18 warnings. Rpmlint (debuginfo) ------------------- Checking: pg_auto_failover-debuginfo-1.6.2-1.fc36.x86_64.rpm pg_auto_failover-debuginfo.x86_64: W: spelling-error Summary(en_US) failover -> fail over, fail-over, spillover pg_auto_failover-debuginfo.x86_64: W: spelling-error %description -l en_US failover -> fail over, fail-over, spillover 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Unversioned so-files -------------------- pg_auto_failover: /usr/lib64/pgsql/pgautofailover.so Source checksums ---------------- https://github.com/citusdata/pg_auto_failover/archive/refs/tags/v1.6.2.tar.gz : CHECKSUM(SHA256) this package : 8af35ac18e39b9b016c5410b317bdd81a3351f0d6f65bb77484d14936d17bb74 CHECKSUM(SHA256) upstream package : 8af35ac18e39b9b016c5410b317bdd81a3351f0d6f65bb77484d14936d17bb74 Requires -------- pg_auto_failover (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) libpq.so.private13-5()(64bit) postgresql-contrib postgresql-server rtld(GNU_HASH) pg_auto_failover-docs (rpmlib, GLIBC filtered): pg_auto_failover(x86-64) pg_auto_failover-llvmjit (rpmlib, GLIBC filtered): pg_auto_failover(x86-64) postgresql-llvmjit pg_auto_failover-debuginfo (rpmlib, GLIBC filtered): pg_auto_failover-debugsource (rpmlib, GLIBC filtered): Provides -------- pg_auto_failover: pg_auto_failover pg_auto_failover(x86-64) pg_auto_failover-docs: pg_auto_failover-docs pg_auto_failover-llvmjit: pg_auto_failover-llvmjit pg_auto_failover-llvmjit(x86-64) pg_auto_failover-debuginfo: debuginfo(build-id) pg_auto_failover-debuginfo pg_auto_failover-debuginfo(x86-64) pg_auto_failover-debugsource: pg_auto_failover-debugsource pg_auto_failover-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -n pg_auto_failover Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Ocaml, fonts, Haskell, PHP, SugarActivity, Python, Java, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ================================================================================================== Revieved by: Michal Schorm Reviewer notes: * The '/usr/lib64/pgsql/pgautofailover.so' file is a plugin for PostgreSQL database. It is not versioned nor is expected to be. * The author provided *.rpmlintrc file to deal with the RPMLint spelling errors that are false positives or otherwise wrong. I _ACCEPT_ this package submission. Marek, feel free to contact me anytime, should you need any additional guidance or just a help in the Fedora import/build/update process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1997378 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
