https://bugzilla.redhat.com/show_bug.cgi?id=2001682 --- Comment #3 from Pavel Valena <pvalena@xxxxxxxxxx> --- (In reply to Jarek Prokop from comment #2) > * invalid license: License should be ASL 2.0 I wonder if gem2rpm should have some hash table... > > * Sources verification: Looks like upstream ships certificate and the gem is > signed, so let's verify the sources > - > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_source_file_verification > - we can verify using gem install > https://guides.rubygems.org/security/#using-gems > - the cert file should probably be moved to `/etc/pki/`, but the guide for > that is quite old. > - https://fedoraproject.org/wiki/Common_Rpmlint_issues#pem-certificate I'll remove it instead. It doesn't make sense to check the .gem file using a cert included in the .gem ... we'd have to add as an additional source. Thanks for spotting! > > Otherwise the package LGTM. > Thanks! Changes: ``` --- a/rubygem-sys-uname.spec +++ b/rubygem-sys-uname.spec @@ -5,7 +5,7 @@ Name: rubygem-%{gem_name} Version: 1.2.2 Release: 1%{?dist} Summary: An interface for returning uname (platform) information -License: Apache-2.0 +License: ASL 2.0 URL: http://github.com/djberg96/sys-uname Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem BuildRequires: ruby(release) @@ -53,7 +53,7 @@ popd %{gem_instdir}/CHANGES.md %license %{gem_instdir}/LICENSE %{gem_instdir}/MANIFEST.md -%{gem_instdir}/certs +%exclude %{gem_instdir}/certs %{gem_libdir} %exclude %{gem_cache} %{gem_spec} ``` https://copr.fedorainfracloud.org/coprs/build/2736351 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2001682 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
