https://bugzilla.redhat.com/show_bug.cgi?id=2003287 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ Status|NEW |POST CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- It's great that you're working on this. Having Numba in Fedora would be wonderful: for me it's one of the important remaining pieces for scientific Python work with a pure Fedora installation. > URL: http://numba.pydata.org/ https:// The %description is written for a person who already knows what llvmlite is and is justifying its existence. We need an explanation for people who have no idea. Maybe something like this (and I'm paraphrasing the existing text based on my understanding only): llvmlite is a wrapper around the llvm compiler created for Numba to interact with the internal llvm internation representation of code. Only the IR builder, optimizer, and JIT compiler APIs are covered. llvmlite consists of a small C wrapper around some parts of the LLVM C++ API that are not already exposed by the LLVM C API, a ctypes wrapper around the C API to allow access from Python code, and a Python implementation of the subset of the LLVM IR builder that is needed for Numba. The "Key Benefits" part could be included, but I'm not sure if it's useful to the users of the package. > %check I think the tests should be enabled by default. This is especially important when we're not using the same llvm version as upstream. When enabled, they pass here without any issue. (Also, maybe add '-v' or equivalent so we get a better log of what was executed…) > LD_LIBRARY_PATH="$LD_LIBRARY_PATH:%{buildroot}/%{python3_sitearch}/llvmlite/binding/" PYTHONPATH="$PYTHONPATH:%{buildroot}/%{python3_sitearch}:%{buildroot}%{python3_sitelib}" %{__python3} runtests.py Maybe: LD_LIBRARY_PATH="%{buildroot}%{python3_sitearch}/llvmlite/binding/" PYTHONPATH="$PYTHONPATH:%{buildroot}%{python3_sitearch}:%{buildroot}%{python3_sitelib}" %{python3} runtests.py (less "/", we expect LD_LIBRARY_PATH to be unset, %python3 is now preferred) '%license LICENSE' is missing. + package name is OK + latest version + license is acceptable for Fedora (BSD) + license is specified correctly + builds and installs OK + fedora-review and rpmlint find no issues (except bogus spelling suggestions and %autorelease misunderstandings) - %check is disabled + BR/R/BR look correct - license is missing from %files Package is APPROVED, but please fix the minor issues pointed out above when importing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
