[Bug 2000763] Review Request: wike - Wikipedia Reader for the GNOME Desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2000763



--- Comment #4 from Gustavo Costa <xfgusta@xxxxxxxxx> ---
(In reply to José Matos from comment #3)
> Hi Gustavo,
>   the spec file is quite simple but I have some doubts about it.

Hi José. I hope I can clarify your doubts.

> BuildRequires:  libhandy1-devel
> Why is this required at build time?

Actually, libhandy1-devel is not required to build Wike. I found out that only
glib2-devel, which is a libhandy's dependency [1], is used. The glib2-devel is
used because of the glib-compile-resources utility [2]. I've already updated
the spec file changing libhandy1-devel to glib2-devel.

> About installation time I suspect that these requirements are dealt by
> python3-gobject, right?
> Requires:       gtk3
> Requires:       libhandy1
> Requires:       webkit2gtk3

gtk3, libhandy1, and webkit2gtk3 are used with python3-gobject [3][4], but
python3-gobject doesn't provide them.

1. dnf repoquery --depends libhandy-devel
2.
https://github.com/hugolabe/Wike/blob/aad1b4c96313b160b68e708a183948b04b1ff15b/data/meson.build#L1
3. https://github.com/hugolabe/Wike/blob/master/src/header.py#L23
4. https://github.com/hugolabe/Wike/blob/master/src/view.py#L25


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux