Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: redet - Regular expression development and execution tool https://bugzilla.redhat.com/show_bug.cgi?id=397211 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From pertusus@xxxxxxx 2007-11-25 17:42 EST ------- %{_datadir} is still not used I suggest: 's|set NonBinPath \[file join /usr local share Redet\];|set NonBinPath \[file join %{_datadir} Redet\];|' redet.tcl > redet.tcl.tmp I also suggest using %{_mandir}/man1/%{name}.1* In any case, * follow guidelines * upstream source 09812846ab653dacbb0adf2a61927fbf redet-8.23.tar.gz * use rpm macros * %files section right APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review