[Bug 2001684] Review Request: python-keyrings-alt - Alternate keyring implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2001684

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
I don't understand why is the component named python-keyrings-alt but the built
package python3-keyrings.alt -- I'd stick to one naming. Honestly, the
%{pypi_name}/%{pretty_name} macros only makes the package harder to read.

------------

> BuildRequires:  %{py3_dist pytest}

This should not be needed.


> %pyproject_buildrequires -t

Since you don't use %tox, you can probably use:

  %pyproject_buildrequires -x testing

To avoid a superfluous dependency on tox.

------------

You can use `%pyproject_save_files keyrings` if your intention is to own the
entire %{python3_sitelib}/keyrings directory.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux