[Bug 2002058] Review Request: cockpit-navigator - A File System Browser for Cockpit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2002058



--- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> ---
(In reply to Neal Gompa from comment #2)
> Spec review notes:
> 
> > %global debug_package %{nil}
> 
> Since this is noarch, we don't need this...
> 

That's left over from upstream's spec file. I'll drop it before I import.

> > /usr/share/cockpit/navigator/*
> 
> This should be "%{_datadir}/cockpit/navigator/" (no asterisk) so that the
> navigator directory is correctly owned too.

Same here; I can submit an updated spec for the review if you prefer or (if
there are no further issues with it) you can approve it and I'll make sure it's
fixed when I import.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux